Refactor Telephony API Wrapper to Fix Parameter Handling #286
Conversation
…d add tests for telephony log retrieval with various parameters
|
@AaronAtDuo Can this get a review please? |
|
@TreWilkins I love the overall restructuring, but I have concerns about some of the stuff you've deleted. In theory, this could constitute a backwards-incompatible change, if anyone has written scripts that directly call some of the lower--level code/utils that you propose to delete or move. This is not necessarily a showstopper, but we try to avoid removing public code with little warning. We'd also need to save this change for a major version change; that would delay this change from merging. Would you like to try to tweak your changes to maintain backwards compatibility, or are you ok waiting for a major version increment? |
@AaronAtDuo Thanks for the feedback! To maintain backward compatibility, I've restored the deleted files and updated some type hints and formatting. I believe this should now be good to go. |
3 participants
Description
Refactored the Telephony API wrapper to properly handle user-provided parameters, ensuring that
mintimeand other arguments are correctly passed in V2 requests. Updatedget_telephony_logto avoid incorrectkwargsnesting and allow proper extraction of parameters.Motivation and Context
This change is required because user-provided arguments, including
mintime, were not being sent in Telephony V2 requests due to incorrectkwargshandling. This fixes the issue by ensuring that parameters are correctly extracted and included in the request.Fixes: #285
How Has This Been Tested?
mintimeand other parameters are correctly passed in V2 requests.Types of Changes